feat: allow momentum coords in to_Vector*D methods + cleanup #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
+ Coverage 82.87% 82.92% +0.05%
==========================================
Files 96 96
Lines 11533 11533
==========================================
+ Hits 9558 9564 +6
+ Misses 1975 1969 -6 ☔ View full report in Codecov by Sentry. |
Saransh-cpp
force-pushed
the
momentum-coords-in-conversion
branch
2 times, most recently
from
e16643d to
4db428e
Compare
7 tasks
Saransh-cpp
commented
Feb 23, 2024
Saransh-cpp
force-pushed
the
momentum-coords-in-conversion
branch
from
6e7b8df to
b12df12
Compare
jpivarski
approved these changes
Feb 28, 2024
Comment on lines
3216
to
+3227
| z: float | None = None, | ||
| pz: float | None = None, | ||
| theta: float | None = None, | ||
| eta: float | None = None, | ||
| t: float | None = None, | ||
| e: float | None = None, | ||
| E: float | None = None, | ||
| energy: float | None = None, | ||
| tau: float | None = None, | ||
| m: float | None = None, | ||
| M: float | None = None, | ||
| mass: float | None = None, |
There was a problem hiding this comment.
If somebody passes both z and pz, or both z and theta for that matter, does the function complain? It shouldn't just pick one and use it—providing (possibly) conflicting arguments should be an error, to prevent silent mistakes.
There was a problem hiding this comment.
Thanks for the review! Yes, the functions was checking for multiple generic coordinates, and I've added momentum coordinated to that check too.
Saransh-cpp
commented
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #382
Paves the way for #422 (make the conversions more user-friendly)
cc: @nsmith-, @iasonkrom, @lgray
Checklist
$ pre-commit run --all-filesor$ nox -s lint)$ pytestor$ nox -s tests)$ cd docs; make clean; make htmlor$ nox -s docs)$ pytest --doctest-plus src/vector/or$ nox -s doctests)Before Merging